[PATCH] fix pointer error in appl_head loadparm.c

Martin Pool mbp at samba.org
Fri Jan 17 06:13:01 GMT 2003


On 17 Jan 2003, Martin Pool <mbp at samba.org> wrote:

> It seems that in the current code any caller to the lp_*_dos()
> functions will get the wrong value!

Correction: only the global lp_*dos parameters.

Specfically:

   1583:FN_GLOBAL_STRING_DOS(lp_serverstring_dos, &Globals.szServerString)
   1599:FN_GLOBAL_CONST_STRING_DOS(lp_defaultservice_dos, &Globals.szDefaultService)
   1604:FN_GLOBAL_CONST_STRING_DOS(lp_auto_services_dos, &Globals.szAutoServices)
   1614:FN_GLOBAL_STRING_DOS(lp_logon_script_dos, &Globals.szLogonScript)
   1616:FN_GLOBAL_STRING_DOS(lp_logon_path_dos, &Globals.szLogonPath)
   1619:FN_GLOBAL_STRING_DOS(lp_logon_home_dos, &Globals.szLogonHome)

So for example, on my PSA, smb.conf wants lp_serverstring_dos()  to be
set to "Hewlett Packard Print Server Appliance", but gdb shows that
it's actually "".  Presumably this is only a cosmetic problem.

Similarly for logon_path and logon_home, though I suppose they don't
matter for a print-only system.

-- 
Martin 



More information about the samba-technical mailing list