Patch for Samba 2.2.6 & 2.2.7 to work on OS X

jra at jra at
Thu Jan 16 06:13:00 GMT 2003

On Thu, Jan 16, 2003 at 01:07:34AM -0500, Michael Bennett wrote:
> So... comments?  Does the patch Do The Right Thing?  Think this patch or 
> something similar could get merged sometime? :)

I remember looking at this patch. The problem is it does something
like :

#ifdef *BSD..
	new code...
	original code.

We don't accept patches that are specific to a particular OS
in this way anymore (unless there's a really good reason). The
correct way to do this is to add a feature test in
that checks if this function works correctly, that way it gets
fixed for all platforms it is broken on.

A patch like that would get accepted immediately. Without it,
we have to write the feature test.


More information about the samba-technical mailing list