permission upgrade during O_TRUNC

[Andrew Bartlett]

On Wed, 2003-01-08 at 13:10, jra at dp.samba.org wrote:
> On Tue, Jan 07, 2003 at 10:53:41AM +0100, steve at griffin.sio2.nl wrote:
> > Hey there, I posted a quick fix for a problem I found with all samba's up
> > to 2.2.7a on the general samba list, which describes the following
> > problem:
> > 
> > In Windows, if you create a file with NORMAL attributes and ALWAYS_CREATE,
> > close the file and then re-create it with, say, HIDDEN and ALWAYS_CREATE,
> > the file *should* be upgraded to HIDDEN. The other way around, ie.
> > starting with HIDDEN and re-creating with NORMAL should keep the file as
> > HIDDEN. Currently, samba always keep the original attributes. This causes
> > windows to incorrectly store hidden and system files from in a roaming
> > profile which gets you that stupid popping-up Desktop.ini in new profiles
> > after the second login (because the files are not hidden on the profile
> > directory). Why windows opens the files as non-hidden first is unknown to
> > me :) Anyways, here is a patch that fixes it. I have tried my best to make
> > it as clean as possible but as I know little of samba internals it may be
> > wrong ...
> > 
> > This works for me, and stops Desktop.ini appearing all over the place. I
> > haven't found any problems with it yet.
> 
> Thanks for this - I didn't apply exactly this patch but it inspired me
> to write something I believe is correct. I applied it to HEAD and 3.0,
> and will back-port to 2.2.x.
> 
> Thanks once again !
> 
> Jeremy.
> 
> PS. Andrew Bartlett - we now pass the torture test OPEN #9 when map
> hidden and map system are set :-).

Thanks - it's good to get the build farm going green again. 

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20030108/ef2ed58a/attachment.bin