[homes] share

[Andrew Bartlett]

On Fri, 2003-01-03 at 04:23, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> 
> > Yep, I think I changed the order of that test - because we use use the
> > 'snum' attached to the vuid if possible, so as to avoid expensive
> > lookups.  The correct fix would be to fix lp_add_home() not to overwrite
> > things when it finds that the home dir share already exists.  (Because
> > all the damage is actually done there - the order that the search is
> > done doesn't matter any more, as the share is added as session setup
> > time).
> > 
> > Unfortunately the fix I was about to commit seems to be the opposite of
> > an earlier 'fix' for a related bug.  I'll need to stare at this a bit
> > more...
> 
> Andrew, Changing the order of the lookup without letting everyone 
> know is a really bad thing.  This is an incompatible change with 2.2.
> Since you described the correct fix, please take care of this.

Yep - will do.  While yes, that is the 'correct' fix, the implementation
in code isn't as straight-forward, particularly if we want changes to a
user's 'homedir' to be updated.  I'll certainly keep an eye on this one.

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20030102/5f2c4688/attachment.bin