REPOST: bug fix?: 2.2.7a, printing/printing.c, print_queue_resume()

[Peter Hurley]

-----Original Message-----
From: samba-technical-bounces+phurley=imaginexd.com at lists.samba.org
[mailto:samba-technical-bounces+phurley=imaginexd.com at lists.samba.org]
On Behalf Of Peter Hurley
Sent: Saturday, February 15, 2003 2:13 PM
To: samba-technical at lists.samba.org
Subject: bug fix?: 2.2.7a, printing/printing.c, print_queue_resume()

With W2k workstation and Samba print server running LPRng:
After resuming a paused print queue by right-mouse clicking on printer
in Printers explorer window (via Control Panel/Printers or Start
Menu/Settings/Printers), the printer status is not updated.  (also, in
the print queue window, Printer/Pause Printing menu option when paused).

This is because the status returned via RPNCNEX rpc is stale.

I believe this is due to a bug in print_queue_resume()
(printing/printing.c, line# 1408).
        if (print_cache_expired(snum)) print_queue_update(snum);

Instead, shouldn't the print cache get flushed after a queue resume
with:
        print_cache_flush(snum);

This is what's done in print_queue_pause().

Thanks,

Peter Hurley
phurley at imaginexd.com