interesting fact about StrCaseCmp

Martin Pool mbp at samba.org
Tue Feb 18 00:01:53 GMT 2003


StrCaseCmp (and strequal) in HEAD has the interesting side-effect that it only
compares the first PSTRING_LEN (1024) bytes of the strings.

I suppose comparing strings longer than that is probably a bit
unlikely, but it still seems kind of dangerous.

Would it be OK to change it to use dynamic allocation?

-- 
Martin 


More information about the samba-technical mailing list