[PATCH] add pread operation to vfs layer

James Peach jpeach at sgi.com
Tue Dec 16 21:59:28 GMT 2003

On Tue, 16 Dec 2003 08:37:14 +0100
Stefan Metzmacher <metze at metzemix.de> wrote:

> James Peach wrote:
> >Hi all,
> >
> >The following diff adds pread/pwrite operations to the VFS layer and
> >makes use of them in the I/O path. This corresponds to bugzilla bug #889.

[snip ifdef's is file I/O path]

> I'd really don't like this #ifdef's and since we have the 
> vfswrap_pread/vfswrap_pwrite functions which emulate pread/pwrite I 
> don't see the need of the #ifdef's in this file

I don't like them either. I added them to prevent a performance regression
on platforms that don't have pread/pwrite since the emulation code does even
more seeking than the original. The response to my previous query showed me
that there are people on this list who do care about samba running on such

James Peach | jpeach at sgi.com | SGI Australian Software Group
I don't speak for SGI.

More information about the samba-technical mailing list