Patch rpc samr "RemoveMemeberForeignDomain" on pre3

Jianliang Lu j.lu at tiesse.com
Wed Dec 3 18:21:34 GMT 2003


> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Jianliang Lu wrote:
> > This patch will fix the wrong implementation of 
>  > "RemoveMemeberForeignDomain" rpc samr.
> 
> I've uploaded a possible patch for this.  See
>     https://bugzilla.samba.org/show_bug.cgi?id=252

I have tried your patch, but it didn't work. I think that you may let a
user can be deleted also if the user is not in any localgroup. I will
do like this (test ok with usrmgr):
--- srv_samr_nt.c   Wed Dec  3 14:49:20 2003
+++ srv_samr_nt.c   Wed Dec  3 17:51:30 2003
@@ -4369,7 +4369,7 @@

    if ( type == SID_NAME_UNKNOWN ) {
        DEBUG(10, ("_samr_remove_sid_foreign_domain: can't operate on what we 
don't ow
n!\n"));
-       return NT_STATUS_NO_SUCH_ALIAS;
+       return NT_STATUS_OK;
     }


Jianliang Lu
TieSse s.p.a.     Ivrea (To) - Italy
j.lu at tiesse.com   luj at libero.it
http://www.tiesse.com


More information about the samba-technical mailing list