[PATCH] Samr RPC torture tests not compiling in Samba4

Anthony Liguori aliguori at us.ibm.com
Tue Dec 2 19:39:58 GMT 2003


Here's a tiny patch to make Samba4 compile.  However, I'm not sure what
the intent of the original code was.  Is there significance to
the 8 bits in the 3rd element of logon_hours?  Is it always safe to
assume that length is > 3?


-- 
Anthony Liguori
Linux/Active Directory Interoperability
Linux Technology Center (LTC) - IBM Austin
E-mail: aliguor at us.ibm.com
Phone: (512) 838-1208
Tie Line: 678-1208
-------------- next part --------------
? samr_logon_hours.diff
Index: torture/rpc/samr.c
===================================================================
RCS file: /cvsroot/samba4/source/torture/rpc/samr.c,v
retrieving revision 1.33
diff -u -r1.33 samr.c
--- torture/rpc/samr.c	2 Dec 2003 00:31:54 -0000	1.33
+++ torture/rpc/samr.c	2 Dec 2003 19:36:56 -0000
@@ -181,9 +181,9 @@
 	TEST_USERINFO_INT(2, country_code, 21, country_code, __LINE__);
 	TEST_USERINFO_INT(2, code_page, 21, code_page, __LINE__);
 
-	TEST_USERINFO_INT(4, logon_hours[3],  3, logon_hours[3], __LINE__);
-	TEST_USERINFO_INT(4, logon_hours[3],  5, logon_hours[3], __LINE__);
-	TEST_USERINFO_INT(4, logon_hours[3], 21, logon_hours[3], __LINE__);
+	TEST_USERINFO_INT(4, logon_hours.bitmap[3],  3, logon_hours.bitmap[3], __LINE__);
+	TEST_USERINFO_INT(4, logon_hours.bitmap[3],  5, logon_hours.bitmap[3], __LINE__);
+	TEST_USERINFO_INT(4, logon_hours.bitmap[3], 21, logon_hours.bitmap[3], __LINE__);
 
 	TEST_USERINFO_INT(9, primary_gid,  1, primary_gid, 513);
 	TEST_USERINFO_INT(9, primary_gid,  3, primary_gid, 513);


More information about the samba-technical mailing list