No subject


Tue Dec 2 03:01:20 GMT 2003


uint32 _lsa_enum_trust_dom(
	pipes_struct *p, 
	LSA_Q_ENUM_TRUST_DOM *q_u, 
	LSA_R_ENUM_TRUST_DOM *r_u)
{
	uint32 enum_context = 0;
	char *dom_name = NULL;
	DOM_SID *dom_sid = NULL;

	if (!find_policy_by_hnd(p, &q_u->pol, NULL))
		return NT_STATUS_INVALID_HANDLE;

	/* set up the LSA QUERY INFO response */
	init_r_enum_trust_dom(r_u, enum_context, dom_name, 
		dom_sid, dom_name != NULL ? NT_STATUS_NO_PROBLEMO :
		NT_STATUS_UNABLE_TO_FREE_VM);
		^^^^^^^^^^^^^^^^^^^^^^^^^^^

Why are we returning this to the client? :-)

	return r_u->status;
}

I agree we should return an error, but this one is a 
little non-intuitive to me.




Cheers, jerry

----------------------------------------------------------------------
   /\  Gerald (Jerry) Carter                     Professional Services
 \/    http://www.valinux.com/  VA Linux Systems   gcarter at valinux.com
       http://www.samba.org/       SAMBA Team          jerry at samba.org
       http://www.plainjoe.org/                     jerry at plainjoe.org

       "...a hundred billion castaways looking for a home."
                                - Sting "Message in a Bottle" ( 1979 )





More information about the samba-technical mailing list