Problem with ads_cached_connection?

[Ken Cross]

Samba-folk:

The nsswitch/winbindd_ads.c module uses "ads_cached_connection" to maintain
an open connection to an LDAP server.  I have found at least one instance
where that isn't working too well.

When viewing the sequence number with wbinfo --sequence, I noticed that
servers would periodically show up "DISCONNECTED", then later (usually)
they'd be OK.  The problem seems to be in using the cached connection.  The
call to ads_USN in the sequence_number routine was returning "Can't contact
LDAP server".

I added a retry in the sequence_number function (blowing away the cached
connection) and the retry always seems to succeed.

I'm speculating here, but is it really valid to leave a connection open
indefinitely?  There can be long intervals between updating sequence
numbers.

Also, if the sequence_number routine fails at times, could other routines
using ads_cached_connection (11 of them) be having problems occasionally?
If so, a more general solution needs to be considered.

Ken
________________________________

Ken Cross

Network Storage Solutions
Phone 865.675.4070 ext 31
kcross at nssolutions.com