memory wasting in get_sock_addr() (samba4)

Stefan (metze) Metzmacher metze at
Fri Aug 15 15:48:20 GMT 2003

At 17:42 15.08.2003 +0200, Stefan (metze) Metzmacher wrote:
>Hi tridge,
>get_sock_addr() is wasting a lot of memory...
>it would be nice if you would apply this patch to samba4.
>get_sock_name() also waste a lot!!! (in 3.0 and 4.0)
>but should be fixed also.

sorry it's only samba4.

but in both there's:

char *name_buf;
alpha_strcpy(name_buf, name_buf, "_-.", sizeof(name_buf));

makes no sense in samba4.

sizeof(name_buf) NOT >= length of the name!

in samba3 sizeof(pstring) >= length of the string

Stefan "metze" Metzmacher <metze at> 

More information about the samba-technical mailing list