[PATCH] move all smb_register_*() to NTSTATUS

Stefan (metze) Metzmacher metze at metzemix.de
Mon Apr 28 14:20:17 GMT 2003


At 11:07 28.04.2003 +0200, Simo Sorce wrote:
>On Mon, 2003-04-28 at 04:00, Jelmer Vernooij wrote:
> > On Sat, Apr 26, 2003 at 03:31:25PM +0200, Stefan (metze) Metzmacher 
> wrote about '[PATCH] move all smb_register_*() to NTSTATUS':
> > > Hi Jelmer,
> >
> > > I have merged in you last changes....
> >
> > > here's the patch that converts all smb_register_*() fn's to return 
> NTSTATUS
> >
> > > also I have introduced a SMB_RPC_INTERFACE_VERSION
> >
> > > and all smb_register_*() fn's have uint16 version as the FIRST parameter
> > > now.
> >
> > > so will not get pain if we want to change the parameter count of such a
> > > function.
> >
> > > smb_register_charset() is the only function witch have no uint16 
> version...
> >
> > Hi Metze!
> >
> > I've looked at this patch and it looks (overall) nice! I'm going to
> > commit it after I've done a few tests later today, except for the
> > info_struct stuff. That's not complete and I'm not really sure whether
> > we want to have that in 3.0 already. Everything depends on everything
> > so I'm not sure whether we can have that working correctly with the
> > current architecture of samba..
>
>Just one thing, why should we use an uint16 for versioning?
>uint32 should be preferable imho, make no sense to use 16bits integers
>today ...

we have version number's witch are <100 so why should use 32 bits for them.

But I would be fine with uint32 also...



metze
-----------------------------------------------------------------------------
Stefan "metze" Metzmacher <metze at metzemix.de> 



More information about the samba-technical mailing list