[PATCH] move all smb_register_*() to NTSTATUS
simo.sorce at xsec.it
Mon Apr 28 09:07:32 GMT 2003
On Mon, 2003-04-28 at 04:00, Jelmer Vernooij wrote:
> On Sat, Apr 26, 2003 at 03:31:25PM +0200, Stefan (metze) Metzmacher wrote about '[PATCH] move all smb_register_*() to NTSTATUS':
> > Hi Jelmer,
> > I have merged in you last changes....
> > here's the patch that converts all smb_register_*() fn's to return NTSTATUS
> > also I have introduced a SMB_RPC_INTERFACE_VERSION
> > and all smb_register_*() fn's have uint16 version as the FIRST parameter
> > now.
> > so will not get pain if we want to change the parameter count of such a
> > function.
> > smb_register_charset() is the only function witch have no uint16 version...
> Hi Metze!
> I've looked at this patch and it looks (overall) nice! I'm going to
> commit it after I've done a few tests later today, except for the
> info_struct stuff. That's not complete and I'm not really sure whether
> we want to have that in 3.0 already. Everything depends on everything
> so I'm not sure whether we can have that working correctly with the
> current architecture of samba..
Just one thing, why should we use an uint16 for versioning?
uint32 should be preferable imho, make no sense to use 16bits integers
Simo Sorce - simo.sorce at xsec.it
Xsec s.r.l. - http://www.xsec.it
via Durando 10 Ed. G - 20158 - Milano
mobile: +39 329 328 7702
tel. +39 02 2399 7130 - fax: +39 02 700 442 399
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 232 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20030428/a77a379f/attachment.bin
More information about the samba-technical