[PATCH] move all smb_register_*() to NTSTATUS

Jelmer Vernooij jelmer at samba.org
Mon Apr 28 02:00:28 GMT 2003

On Sat, Apr 26, 2003 at 03:31:25PM +0200, Stefan (metze) Metzmacher wrote about '[PATCH] move all smb_register_*() to NTSTATUS':
> Hi Jelmer,

> I have merged in you last changes....

> here's the patch that converts all smb_register_*() fn's to return NTSTATUS

> also I have introduced a SMB_RPC_INTERFACE_VERSION

> and all smb_register_*() fn's have uint16 version as the FIRST parameter 
> now.

> so will not get pain if we want to change the parameter count of such a 
> function.

> smb_register_charset() is the only function witch have no uint16 version...

Hi Metze!

I've looked at this patch and it looks (overall) nice! I'm going to
commit it after I've done a few tests later today, except for the
info_struct stuff. That's not complete and I'm not really sure whether
we want to have that in 3.0 already. Everything depends on everything
so I'm not sure whether we can have that working correctly with the
current architecture of samba..


Jelmer Vernooij                                      <jelmer at samba.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20030428/2d9fc537/attachment.bin

More information about the samba-technical mailing list