CIDR notation bug (round 3?) (Re: CVS update: samba/source/lib)

Gerald (Jerry) Carter jerry at samba.org
Sat Apr 26 16:19:55 GMT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Fri, 25 Apr 2003 aono at cc.osaka-kyoiku.ac.jp wrote:

> (on samba-jp mailing list) it cannot work on x86 platform.
> With some thought inspired by follow-up mail (and simple
> test), we need to change byte order in this case.
> 
> But I think location of htonl() in recent commit (1.37
> etc.) is wrong. (ex. 192.168.0.0/255.255.255.0 may not
> match host 192.168.0.1 on some platforms (including x86).)
> I found similar code in interpret_interface() in
> lib/interface.c , so (more) correct fix is:

I agree.  Thanks.  FIxed in all branches.





cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.0 (GNU/Linux)
Comment: For info see http://quantumlab.net/pine_privacy_guard/

iD8DBQE+qrGrIR7qMdg1EfYRAkYlAJ4vBmOaMvoqdmjuJ3e81Wfb/MxFlQCgkfB4
KBrAi2s1bdLRE6VP953ztTw=
=AvSh
-----END PGP SIGNATURE-----



More information about the samba-technical mailing list