CVS update: samba/source/param

Gerald (Jerry) Carter jerry at samba.org
Wed Apr 23 21:00:45 GMT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 24 Apr 2003, Andrew Bartlett wrote:

> I noticed *SMBSERVER being subed into a %L macro.
> 
> For most of samba, we want %L to return our netbios name, if the client
> didn't tell us 'our name'.
> 
> However, it looked like the printing code was trying to use the IP
> address instead - calling a slightly different function - for some of
> the return values.  So, that's why I have left the slightly different
> functions for this.  They probably should be in the same file...

Originally we would blindly write the global_myname() string 
into the RPC replies in the spoolss code.  This caused our 
testers a lot of problems when the windows client was using 
an IP address instead of a name.  This also made the printing code work 
with netbios aliases I think.

Hmmm...now that I think about it, %L should be the netbios name
used by the client so I think *SMBSERVER (or *SMBSERV) is what 
it should have been.  In this case, I'm not sure your change 
was the right thing to do.  Do you follow me ?




cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.0 (GNU/Linux)
Comment: For info see http://quantumlab.net/pine_privacy_guard/

iD8DBQE+pv8AIR7qMdg1EfYRAgPvAJ9bAphYsNoxu0PC+HruWXy+wopFAQCdFT6n
NGmYXgjFxWiYHuBmHl25cDw=
=LXj6
-----END PGP SIGNATURE-----



More information about the samba-technical mailing list