CVS update: samba/source/param
Andrew Bartlett
abartlet at samba.org
Wed Apr 23 15:09:58 GMT 2003
On Thu, 2003-04-24 at 00:16, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Wed, 23 Apr 2003 abartlet at samba.org wrote:
>
> >
> > Date: Wed Apr 23 01:44:04 2003
> > Author: abartlet
> >
> > Update of /home/cvs/samba/source/param
> > In directory dp.samba.org:/tmp/cvs-serv4769/param
> >
> > Modified Files:
> > Tag: SAMBA_3_0
> > loadparm.c
> > Log Message:
> > Try to keep existing behaviour for our printing code - never return
> > global_myname(), always either the name the client called us, or if they
> > didn't call us anything useful, our IP address.
> >
> > Jerry, can you check this?
>
> This looks ok. I can't think of any time when we would need to know
> whether it was *SMBSERVER or *SMBSERV.
>
> btw...I didn't pay attention, but what prompted this change ?
> Was something broken ?
I noticed *SMBSERVER being subed into a %L macro.
For most of samba, we want %L to return our netbios name, if the client
didn't tell us 'our name'.
However, it looked like the printing code was trying to use the IP
address instead - calling a slightly different function - for some of
the return values. So, that's why I have left the slightly different
functions for this. They probably should be in the same file...
Andrew Bartlett
--
Andrew Bartlett abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team abartlet at samba.org
Student Network Administrator, Hawker College abartlet at hawkerc.net
http://samba.org http://build.samba.org http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20030424/ca5162cb/attachment.bin
More information about the samba-technical
mailing list