clean up strequal()?

Andrew Bartlett abartlet at samba.org
Thu Apr 10 09:01:08 GMT 2003


On Thu, 2003-04-10 at 12:46, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 10 Apr 2003, Andrew Bartlett wrote:
> 
> > My only problem comes from the fact that some things are paths, and are
> > therefore case sensitive, while others are not - but I'm not fussed
> > about this.
> 
> I thought the proposal was about making parameter case insensitive.
> Not values.  Did I misunderstand?

OK - back to what I actually meant:

Some parts of the new modules system use 'strequal' in their internal
loops, matching module names in smb.conf with builtin modules and others
brought in from .so files.

I think this should be case sensitive, and when we audit strequal()
users, we might want to change these to strcmp(), not strcasecmp().

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20030410/7a67b2ce/attachment.bin


More information about the samba-technical mailing list