Crash in passdb/pdb_ldap.c

[Stefan (metze) Metzmacher]

Hi Andrew,

I have made a patch for this...

metze

At 20:45 07.04.2003 +0200, Jelmer Vernooij wrote:
>-----BEGIN PGP SIGNED MESSAGE-----
>Hash: SHA1
>
>On Monday 07 April 2003 20:42, Jelmer Vernooij wrote:
> > Hi,
> >
> > My server is crashing at the ldap_mods_free() in the part of
> > passdb/pdb_ldap.c (HEAD, around line 1523) pasted below.. Can we assume
> > that if
> > init_ldap_from_sam() fails we can free mods ?
> >
> >      if (!init_ldap_from_sam(ldap_state, entry, &mods, newpwd,
> >                 element_is_set_or_changed)) {
> >         DEBUG(0, ("ldapsam_add_sam_account: init_ldap_from_sam
> > failed!\n")); ldap_msgfree(result);
> >         ldap_mods_free(mods, 1);
> >         return NT_STATUS_UNSUCCESSFUL;
> >     }
>
>It looks like we already call ldap_mods_free() in init_ldap_from_sam() if
>we had created an LDAPMod... Can someone confirm to me that this is a bug?


metze
-----------------------------------------------------------------------------
Stefan "metze" Metzmacher <metze at metzemix.de> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pdb_ldap-09.diff
Type: application/octet-stream
Size: 2485 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20030408/858a1356/pdb_ldap-09.obj