[PATCH] FIX vfs_recycle.c seg fault

Simo idra at samba.org
Mon Apr 7 22:48:17 GMT 2003


On Mon, 2003-04-07 at 20:27, Stefan Metzmacher wrote:
> At 20:16 07.04.2003 +0200, Jelmer Vernooij wrote:
> >-----BEGIN PGP SIGNED MESSAGE-----
> >Hash: SHA1
> >
> >On Monday 07 April 2003 18:57, Stefan (metze) Metzmacher wrote:
> > > HI all,
> > >
> > > here's a small patch with prevends vfs_recycle.c from segfaulting
> > > when 'keep dir tree  = True'
> > >
> > > and fixes the prototype of unlink_internal to get a pstring instead of char
> > > *
> >Why use a seperate malloc and not just a pstring there as well?
> 
> I would also preferr this too, but I don't want the code too much.

NO, please! Keep using malloced buffers in new code if possible.

Simo.

-- 
Simo Sorce    -  idra at samba.org
Samba Team    -  http://www.samba.org
Italian Site  -  http://samba.xsec.it


More information about the samba-technical mailing list