Crash in passdb/pdb_ldap.c

[Jelmer Vernooij]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 07 April 2003 20:42, Jelmer Vernooij wrote:
> Hi,
>
> My server is crashing at the ldap_mods_free() in the part of
> passdb/pdb_ldap.c (HEAD, around line 1523) pasted below.. Can we assume
> that if
> init_ldap_from_sam() fails we can free mods ?
>
>      if (!init_ldap_from_sam(ldap_state, entry, &mods, newpwd,
>                 element_is_set_or_changed)) {
>         DEBUG(0, ("ldapsam_add_sam_account: init_ldap_from_sam
> failed!\n")); ldap_msgfree(result);
>         ldap_mods_free(mods, 1);
>         return NT_STATUS_UNSUCCESSFUL;
>     }

It looks like we already call ldap_mods_free() in init_ldap_from_sam() if 
we had created an LDAPMod... Can someone confirm to me that this is a bug?

Jelmer

- -- 
Jelmer Vernooij <jelmer at nl.linux.org> - http://nl.linux.org/~jelmer/
 20:44:58 up 22:04,  9 users,  load average: 0.27, 0.20, 0.18
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+kcdfPa9Uoh7vUnYRAr6uAJ9UuxTbnVxdTHAoFjJ8cP4IZa+efQCeK84u
jZdStKIeUuSVfSIS1JGwgqs=
=r5/O
-----END PGP SIGNATURE-----