[PATCH] fix smb signing

Andrew Bartlett abartlet at samba.org
Sun Apr 6 02:24:05 GMT 2003


On Fri, 2003-04-04 at 19:31, Stefan (metze) Metzmacher wrote:
> Hi Andrew,
> 
> here's a small fix:
> 
> we should tell the server that we support signing :-)

I applied your patch to my tree, then realized I had already done it -
in libsmb/smb_signing.c there is a 'mark packet signed' function.  This
marks only signed packets, which is what I understand the SNIA spec and
my wire sniffs to indicate.

I could not reproduce a difference in behavior with our without the
patch, except that we would mark a negprot as 'signed' when it certainly
is not...

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20030406/11ef5119/attachment.bin


More information about the samba-technical mailing list