Possible solution for "Bug in rpcclient in 2.2.8".

[Arcady Chernyak]

Hi
I am working with "Debian"; I had the same problem and solved it by adding 3
lines to file rpcclient.c 
Line 645 was:
	pstrcpy(server, "");
Now its:
/* Arcady fix (3 following lines)*/
	pstrcpy(password, ""); /* new initialization */
	pstrcpy(username, "");
	pstrcpy(domain,   "");
	pstrcpy(server, "");

I can't understand why other OS does not feel this problem (uninitialized
strings), and I suggest using this change for all SAMBA version and
releases.

Best regards
	Arcady




-----Original Message-----
From: Mike Brodbelt [mailto:m.brodbelt at acu.ac.uk] 
Sent: Thursday, April 03, 2003 3:44 AM
To: samba-technical
Subject: Bug in rpcclient in 2.2.8


Hi,

Running Samba 2.2.8 on Debian Woody, using packages from
http://people.debian.org/~peloy/samba/.

The rpcclient binary isn't happy:-

$ dpkg -S `which rpcclient`
smbclient: /usr/bin/rpcclient
$ dpkg -s smbclient | grep Version
Version: 2.2.8-1.woody
$ rpcclient -U mb server
Password:
failed session setup
Cannot connect to server.  Error was NT_STATUS_LOGON_FAILURE

>From a machine running Debian testing with Samba 2.2.3:-

$ dpkg -S `which rpcclient`
smbclient: /usr/bin/rpcclient
$ dpkg -s smbclient | grep Version
Version: 2.2.3a-6
$ rpcclient -U mb server
Enter Password:
session setup ok
Domain=[MILKY-WAY] OS=[Unix] Server=[Samba 2.2.8-1.woody for Debian]
rpcclient $>


The first machine is the server, if that's important.

Mike.