acct_ctrl in context_sam_enum_accounts

[Andrew Bartlett]

Jelmer Vernooij wrote:
> 
> On Sun, Sep 29, 2002 at 03:04:25PM +1000, Andrew Bartlett wrote:
> > "Stefan (metze) Metzmacher" wrote:
> > >
> > > At 18:27 26.09.2002 +0200, Jelmer Vernooij wrote:
> > > >Hi all!
> > > >
> > > >What kind of a value is the acct_ctrl argument of
> > > >context_sam_enum_accounts supposed to be?
> > > >
> > > >It should be possible to list all accounts, that's why the current
> > > >implementation isn't very usable...
> > >
> > > list all accounts with    acct_ctrl = (ACB_NORMAL | ACB_WSTRUST |
> > > ACB_SVRTRUST | ACB_DOMTRUST | ACB_TEMPDUP | ACB_MNS);
> > >
> > > I add a patch for this
> >
> > I think this is the wrong way to do it.  If the acb_mask is 0, then the
> > backend should return all accounts.  Reasoning:  This is how the SAMR
> > pipe code behaves, so it makes some sense to do the same.  Otherwise, a
> > 'list all accounts' should be just (~0)
> >
> > I'll take the rest of this patch however :-)
> I already committed this (including the other stuff, so we should probably back that out again)

Done.  Further resoning is to avoid having hard-coded bitmasks in
samtest, I think the backend (or possilbly the interface) is in the best
position to determine what a 'default' query should return.

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net