strupper() on username and domain in cli_session_setup_nt1()?

Gerald Carter jerry at
Mon Sep 23 13:31:00 GMT 2002

On Mon, 23 Sep 2002, Tim Potter wrote:

> I'm just wondering whether it is strictly necessary to uppercase the
> username and domain name when performing a session setup.  Applying the
> following patch should not break anything and would make smbclient be
> able to test for case sensitivity bugs in the remote server.
> The behaviour of uppercasing everything seems to be peculiar to Windows
> 9x.  According to some testing done by the HP guys and girls, NT and
> 2000 send across the case of the username as it was created in the SAM,
> whereas XP sends the case the user logged in with.

The patch looks fine to me Tim.  

cheers, jerry
 SAMBA Team                             
 "Sam's Teach Yourself Samba in 24 Hours" 2ed.      ISBN 0-672-32269-2
 --"I never saved anything for the swim back." Ethan Hawk in Gattaca--

More information about the samba-technical mailing list