[PATCH]block.c (recycle.c)

[Alexander Bokovoy]

On Mon, Sep 02, 2002 at 07:27:07AM +0200, Stefan (metze) Metzmacher wrote:
> 
> >HI J?rgen,
> 
> First the update version of recycle.c looks good!
> 
> But I would like to change something:
> 
> 1. rename recycle.c to vfs_recycle.c ! All samba module should be prefixed 
> with the subsystem prefix (e.g. vfs_recycle.so , pdb_xml.so, sam_ads.so ...)
Yes.

> 2. I think it would be nicer to don't use /etc/samba/recycle.conf and use 
> the following in smb.conf:
> 
> [homes]
> vfs object = /usr/lib/samba/vfs_recycle.so
> vfs: recycle: bin = .recycle/%u
second : isn't needed.

> vfs: recycle mode = KEEP_DIRECTORIES|VERSIONS
> vfs: recycle maxsize = 0
> vfs: recycle exclude = *.tmp|*.temp|*.obj|~$*|*.$$$
> vfs: recycle excludedir = /tmp|/temp|/trash
> vfs: recycle noversions = *.doc|*.xls|*.ppt
> 
> or this:
> 
> [homes]
> vfs object = /usr/lib/samba/vfs_recycle.so
> vfs_recycle: path = .recycle/%u
> vfs_recycle: mode = KEEP_DIRECTORIES|VERSIONS
> vfs_recycle: maxsize = 0
> vfs_recycle: exclude = *.tmp|*.temp|*.obj|~$*|*.$$$
> vfs_recycle: excludedir = /tmp|/temp|/trash
> vfs_recycle: noversions = *.doc|*.xls|*.ppt
This involves adding new parameters to loadparm.c which isn't acceptable
actually. Better use parametrical options from above.
> 
> 
> metze
> -----------------------------------------------------------------------------
> Stefan "metze" Metzmacher <metze at metzemix.de>

-- 
/ Alexander Bokovoy
---
Drop the vase and it will become a Ming of the past.
		-- The Adventurer