mangling char ignored in mangle_hash2.c ...

[Simo Sorce]

It was decided to fix the mangling char to '~', lp__mangling_char() was
maintained for compatibility with the old style module.
We choosed also to fix it at seventh char position to avoid broken
applications that make assumptions on the mangling char and also moved
every unusable char to be displayed as a single '_', the previous
semantics can be found in mangle_hash.c

abartlet already give other reasons, performance is also one of them, we
do a lot of mangling.

Simo.


On Sun, 2002-09-01 at 09:07, Richard Sharpe wrote:
> On Sun, 1 Sep 2002, Andrew Bartlett wrote:
> 
> > Richard Sharpe wrote:
> > > 
> > > Hi,
> > > 
> > > Having looked at mangle_hash2, it is clear that the mangling char is hard
> > > coded. I am sure this is not intended.
> > > 
> > > Should I fix it?
> > 
> > While tridge would be a much better one to comment, I will say this:
> > 
> > The new mangling scheme was designed to be very fast, and not
> > particulary flexible.  In fact, it could be argued that the inflexibilty
> > is a feature - becouse changes to the mangling scheme actually have some
> > nasty consequenses.  (8.3 names are stored by some applications etc,
> > hence why we have not moved to hash2 in 2.2 by default)
> 
> Oh, I agree with that, however, hard-coding ~ when lp_mangling_char() 
> would be almost as fast, and would have the same effect in the default 
> case, seems wrong.
> 
> Regards
> -----
> Richard Sharpe, rsharpe at ns.aus.com, rsharpe at samba.org, 
> sharpe at ethereal.com
-- 
Simo Sorce - simo.sorce at xsec.it
Xsec s.r.l.
via Durando 10 Ed. G - 20158 - Milano
tel. +39 02 2399 7130 - fax: +39 02 700 442 399
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 232 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20020901/53d17d15/attachment.bin