Separating info out of the libsmbclient.h include file

Richard Sharpe root at ns.aus.com
Mon Oct 21 20:40:01 GMT 2002


On Mon, 21 Oct 2002, Tom Jansen wrote:

> Tom Jansen wrote:
> > Hi Richard,
> > 
> > Richard Sharpe wrote:
> > 
> >> A problem has arrisen with libsmbclient in head, in that there is too 
> >> much
> >> info exposed in libsmbclient.h.
> 
> New idea:
> 
> example for internal include file:
> 
> typedef struct _SMBCSRV {
> 	struct cli_state cli;
> 	dev_t dev;
> 	BOOL no_pathinfo2;
> 	int server_fd;
> 
> 	struct _SMBCSRV *next, *prev;
> } SMBCSRV;
> 
> 
> In the client include file we could just do:
> 
> typedef struct _SMBCSRV SMBCSRV;
> 
> The client _only_ uses pointers to this type of structs so size does not 
> matter. All the allocating of memory is done inside libsmbclient.
> 
> This is IMHO a quite nice solution. I ripped it from the FILE type glibc 
> offers.
> 
> Please let me know what you think about this solution.

I am travelling at the moment, so it will take a few days to respond.

Regards
-------
rsharpe at ns.aus.com, www.richardsharpe.com,
sharpe at samba.org, sharpe at ethereal.com




More information about the samba-technical mailing list