use sendfile loadparm.c / docs inconsistency

[Pierre Belanger]

Hi,

[ Yeah, me again about this sendfile stuff ;-) ]

I notice some inconsistence in the documentations...

"smb.conf.5" is listing "use sendfile" in the

  "COMPLETE LIST OF GLOBAL PARAMETERS"

area, and later in the same manual, it shows
"use sendfile" has a "shared parameter":

  "use sendfile (S)"

I think this parameter should be moved from
the "COMPLETE LIST OF GLOBAL PARAMETERS" to
"COMPLETE LIST OF SERVICE PARAMATERS".

I also notice in param/loadparm.c :

{"use sendfile", P_BOOL, P_LOCAL,
&sDefault.bUseSendfile, NULL, NULL, FLAG_SHARE},

ps: Is there really a need to control "use sendfile"
    per share? I don't see one, if sendfile is working
    why not turn it on... that's my opinion!

Anyhow, I think the FLAG_GLOBAL is missing?!?!

Thank you,
Pierre B.

__________________________________________________
Do you Yahoo!?
Faith Hill - Exclusive Performances, Videos & More
http://faith.yahoo.com