[PATCH] give add printer command the printer comment
jerry at samba.org
Mon Oct 7 16:42:00 GMT 2002
On Mon, 30 Sep 2002, Stefan (metze) Metzmacher wrote:
> Hi Jerry,
> here's a small patch to add the printer comment as parameter for the add
> printer command.
This is probably a legitimate need. I also think we should remove
the "win9x driver location" and "remote machine netbios name" parameter
but I need to find out why they were added in the first place.
I spoke with John Reilly about this earlier today and have a little
more investigation to do before i'm confident.
> It also fix that smbd reloads the printers right.
I don't think is is a complete fix actually. The problem is
that the current implementation of add_printer_hook() really
only works if you have the [printers] share defined. We need
reload non-[printers] services as well. So the final fix
will have to be a little more generic. I'm working on it
today (or tomorrow).
> what is left to do is send a notify to the client that the printer list
> is updated.
Good point. I'll have to look into this.
More information about the samba-technical