disign of the VFS modules

Stefan (metze) Metzmacher metze at metzemix.de
Tue Nov 26 12:40:59 GMT 2002

At 12:08 26.11.2002 +0200, Alexander Bokovoy wrote:
>vfs_private was designed for it. Modules which use global vars should be
>fixed, indeed, I've tried to do so during introduction of stacked VFS.
>But in current CVS HEAD we have a number of misuse of vfs_private, for
>example, in vfs_recycle, which uses conn->vfs_private as (void*) storage
>of its own data instead of storing that data in vfs_handle->data
>passed at vfs_init() stage.
>So, this is should also be fixed. And module should not directly access
>conn->vfs_private as it may correspond to different module
>(conn->vfs_private is a list of handles actually). Instead,
>vfs_handle passed at vfs_init() stage should be stored somewhere and
>referenced later.

we need a way to access vfs_handle in all module functions but don't make 
vfs_handle global!!! conn->vfs_private is the head of a DLIST and we need a 
way to access the right element of this list.

has anybody an idea???

>/ Alexander Bokovoy
>byob, v:
>         Believing Your Own Bull

Stefan "metze" Metzmacher <metze at metzemix.de>

More information about the samba-technical mailing list