Simo Sorce idra at samba.org
Wed May 29 04:38:59 GMT 2002

I agree, I was thinking the same yesterday evening.
I will have to check srv_samr_nt.c too because I have not changed it
when found sid_peek_rid, and I'm not sure the domain is check every

On Wed, 2002-05-29 at 13:01, Andrew Bartlett wrote:
> It might be worth reworking that function to take an 'expected domain
> sid' argument.  That way we can ensure that we don't make (incorrect)
> assumtions about what the sid beeing 'peeked at' represents.  I can
> imagine some subtle (and really annoying to track down) bugs being
> introduced/prevented depending on what checks we do here.

Simo Sorce
Una scelta di liberta': Software Libero.
A choice of freedom: Free Software.

More information about the samba-technical mailing list