Andrew Bartlett abartlet at pcug.org.au
Wed May 29 04:05:02 GMT 2002

"Stefan (metze) Metzmacher" wrote:
> And I remove all pdb_get_rid()'s and replace them with
> sid_peek_rid(pdb_get_sid())...

It might be worth reworking that function to take an 'expected domain
sid' argument.  That way we can ensure that we don't make (incorrect)
assumtions about what the sid beeing 'peeked at' represents.  I can
imagine some subtle (and really annoying to track down) bugs being
introduced/prevented depending on what checks we do here.

Andrew Bartlett

Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net

More information about the samba-technical mailing list