tabs and formating - was Re: [PATCH] winbind id assignment module

John E. Malmberg wb8tyw at
Fri May 24 08:07:03 GMT 2002

Mike Gerdts wrote:
> On Sat, 2002-05-18 at 20:54, Andrew Bartlett wrote:
>>This looks *much* better.
>>I'm not sure on the 'reload' functionality, but I suppose its a good
>>idea.  Other than minor things like indenting,   (Try 8-space tabs) I
>>think this is well on its way to inclusion.
> As for spacing... I tried to follow the standard that I saw in the file
> already.  I used 4 character tabs, but they should have expanded out
> OK.  I thought that others were using 4 character tabs as well because
> sections of winbindd_idmap.c have tabs expanded to four characters.  In
> any case, the next version that goes out will get rid of any expanded
> tabs and any necessary reformatting for prettiness will take place.

Almost all terminal emulators and printing devices assume that the tab
character stops on 8 character boundaries.

Some editors will locally override it.

So be aware that if you have set your tab stops to 4 characters, it will 
probably show up as 8 characters on many systems.

Using all spaces instead of tabs solves that problem, but it really is
convenient to have tabs there when using the arrow keys to navigate in a 

There does not seem to be a style book for coding on the SAMBA project.

wb8tyw at
Personal Opinion Only

More information about the samba-technical mailing list