[PATCH] Various

Andrew Bartlett abartlet at pcug.org.au
Fri May 24 03:05:02 GMT 2002

Jelmer Vernooij wrote:
> Hi,
> Here's the patch that includes this afternoon's fix for current CVS,
> together with some other things:
> - fix passdb, don't loop when loading all backends fails
> - passdb fails when loading of at least one backend fails
> - convert net to popt
> - convert status to popt
> - adapt examples/pdb/ to multiple passdb system
> - add dynamic debug class example to examples/pdb/

Commited, with some reformatting but without the code for passdb load

Can you rewrite this to use an lp_list()?  (and add a different wrapper
to take a text string for pdbedit etc) 

Also, ensure that you don't leak memory.

In particualr, don't miss the memory created in earlier loop cycles by
sucessful pdb backends. This should all be on the talloc context, so a
'free_pdb_context()' should do it.

Finally, don't discard the NT_STATUS return - you should instead log it
and return that to the caller.  Only return 'INVALID_PARAMATER' if the
selected backend wasn't in the list etc.

Andrew Bartlett

Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net

More information about the samba-technical mailing list