Proposed code cleanup
Andrew Bartlett
abartlet at pcug.org.au
Thu May 23 18:22:01 GMT 2002
On Fri, 24 May 2002, Tim Potter wrote:
> On Thu, May 23, 2002 at 01:01:05AM +1000, Andrew Bartlett wrote:
>
> > This allowed me to remove cli_pipe_util.c, which was calling
> > cli_establish_connection.
> >
> > tpot: I'm not sure what direction you were going with the client stuff,
> > and
> > you may well have been wanting the init functions. If thats the case,
> > give
> > me a yell and I'll reimplement them against cli_full_connection.
>
> I do use those silly pipe connection functions in the python wrappers
> but that's about it. They turned out to be less useful than I thought.
>
> Anyway - that looks like a good patch. I've been dying to get rid of all
> those silly make_nmb_name() calls everywhere but was not brave enough.
I'll proabably add a cli_pipe_connection() function (feel free to suggest
a better name) that just calls cli_full_connection, but with IPC$ implicit
and instead specifying the pipe to setup.
How does that sound?
Andrew,
--
Andrew Bartlett abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team abartlet at samba.org
Student Network Administrator, Hawker College abartlet at hawkerc.net
http://samba.org http://build.samba.org http://hawkerc.net
More information about the samba-technical
mailing list