[PATCH] winbind id assignment module

Mike Gerdts gerdts at bellsouth.net
Sat May 18 20:33:02 GMT 2002

On Sat, 2002-05-18 at 20:54, Andrew Bartlett wrote:
> This looks *much* better.
> I'm not sure on the 'reload' functionality, but I suppose its a good
> idea.  Other than minor things like indenting,   (Try 8-space tabs) I
> think this is well on its way to inclusion.

The reload functionality was initially intended to be only load().  My
initial look at the existing code suggested that it would get called
again after getting a HUP (I have to look into that though...).  To me
it looked as though it would be easiest just to make it be able to
handle a reload.  I think that it should work as it is, but I haven't
tested it.  The two things that I would want to test are 1) does it do
what you expect, and 2) does it free up all resources related to the
file such that someone debugging a module can count on a day of HUPs
rather than restarts does end up with 50 copies still mapped.

As for spacing... I tried to follow the standard that I saw in the file
already.  I used 4 character tabs, but they should have expanded out
OK.  I thought that others were using 4 character tabs as well because
sections of winbindd_idmap.c have tabs expanded to four characters.  In
any case, the next version that goes out will get rid of any expanded
tabs and any necessary reformatting for prettiness will take place.

> I like the checking of the .so at loadparm time - its a nice touch.



More information about the samba-technical mailing list