[PATCH] winbind id assignment module

Andrew Bartlett abartlet at pcug.org.au
Sat May 18 17:09:02 GMT 2002

Mike Gerdts wrote:

> http://www.cae.wisc.edu/~gerdts/samba/idmap_file-0.0.3.tar.gz
> Please don't sugar coat the comments on this rev of the patch.  It makes
> it so hard to figure out what people really think of it.  :)

I don't think I actually looked at the code for the first patch, only
the comments.  Unless a patch is *really* big (in which case you should
consider why this is the case) you would do well to always include the
patch an either an inline or attached diff, not as a tarball. 

This lowers the 'cost' of reviewing it, becouse I can just read it
easily - particuarly when I'm just using mutt on a remote server etc.

I'll try to get time to have a look a this, and get back to you.

Andrew Bartlett

Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net

More information about the samba-technical mailing list