One more compile warning fix for Solaris

Richard Bollinger rabollinger at attbi.com
Fri May 17 13:33:01 GMT 2002


Better yet - to match the declaration in proto.h we should use socklen_t.:

--- ../source/smbd/oplock.c Fri May 17 07:16:51 2002
+++ ./smbd/oplock.c Fri May 17 16:27:55 2002
@@ -76,7 +76,7 @@
 BOOL receive_local_message(fd_set *fds, char *buffer, int buffer_len, int timeout)
 {
  struct sockaddr_in from;
- int fromlen = sizeof(from);
+ socklen_t fromlen = sizeof(from);
  int32 msg_len = 0;
 
  smb_read_error = 0;



----- Original Message ----- 
From: "Matt Seitz" <matt.seitz at quantum.com>
To: <samba-technical at samba.org>
Sent: Friday, May 17, 2002 4:09 PM
Subject: RE: One more compile warning fix for Solaris


From: Richard Bollinger [mailto:rabollinger at attbi.com]
>- int fromlen = sizeof(from);
>+ unsigned int fromlen = sizeof(from);

Wouldn't the following be more portable?
size_t fromlen = sizeof(from);

Sincerely,

Matt Seitz
Senior Software Engineer
Quantum Corporation






More information about the samba-technical mailing list