[FIX] HEAD & 3_0 winbindd_proto - Makefile.in

abartlet at samba.org abartlet at samba.org
Thu May 16 22:53:02 GMT 2002


On Fri, May 17, 2002 at 07:44:14AM +0200, Stefan (metze) Metzmacher wrote:
> I noticed a bug in HEAD's and 3_0's Makefile(Makefile.in)
> 
> when I run make clean 'nsswitch/winbindd_proto.h' is deleted, but when I 
> run make it's not created!
> If I run 'cvs update' I got winbindd_proto.h from CVS.
> 
> Here's a patch for the Makefile.in,
> I would preferr to delete winbindd_proto.h from CVS.
> 
> -------------------------------------------------------------------------------
> --- HEAD/source/Makefile.in     Fri May 17 07:31:56 2002
> +++ HEAD-fix/source/Makefile.in Thu May 16 13:54:51 2002
> @@ -470,7 +470,7 @@
>   ######################################################################
>   # now the rules...
>   ######################################################################
> -all : SHOWFLAGS include/proto.h include/wrepld_proto.h include/build_env.h 
> $(SPROGS) $(PROGS) $(WINBIND_PROGS) $(WINBIND_SPROGS) $(LPROGS) $(SHLIBS)
> +all : SHOWFLAGS headers $(SPROGS) $(PROGS) $(WINBIND_PROGS) 
> $(WINBIND_SPROGS) $(LPROGS) $(SHLIBS)

This isn't a good idea, as the header files will declare 'I am up to date'
(becouse getting the dependcies to make them correctly dependent on their .c
files didn't work on all the platforms.)

>   pam_smbpass : SHOWFLAGS bin/pam_smbpass. at SHLIBEXT@
> 
> @@ -855,8 +855,7 @@
>            -h _WREPLD_PROTO_H_ $(builddir)/include/wrepld_proto.h \
>            $(WREPL_OBJ1)
> 
> -headers:
> -       $(MAKE) delheaders include/proto.h include/build_env.h 
> include/wrepld_proto.h winbindd_proto
> +headers: include/proto.h include/build_env.h include/wrepld_proto.h 
> winbindd_proto

Again, this will mean that a 'make proto' or 'make headers' will not
do anything.

Andrew Bartlett





More information about the samba-technical mailing list