[PATCH] winbind kills nscd on Solaris

[Mike Gerdts]

On Thu, 2002-05-09 at 22:58, Tim Potter wrote:
> On Fri, May 10, 2002 at 11:10:58AM +1000, Tim Potter wrote:
> 
> > > Solaris has a couple extra fields in struct passwd.  Since getpwent(3c)
> > > says that pw_age and pw_comment are not used, it seems reasonable not to
> > > fill them in.  nscd may not use them, but assumes that they at least are
> > > pointers to allocated buffers.  Since they are are not pointers to
> > > allocated buffers, a SEGV occurs.
> 
> OK I've checked in a patch to the HEAD branch.  Would you mind seeing if
> this correctly fixes the problem?  If so I'll merge it into the other
> branches.
> 
> 
> Tim.

One question about your implementation...


#if HAVE_PASSWD_PW_COMMENT
        result->pw_comment = "";
#endif

#if HAVE_PASSWD_PW_AGE
        result->pw_age = "";
#endif


Does "" get allocated statically, or on the stack?  If it gets allocated
on the stack, then garbage could replace it at some time in the future.

Mike