BUG: 2.2.4: failed getpass test without system popt

[Borsenkow Andrej]

Test program getpass.c indirectly includes popt. Unfortunately, configure
tests for popt too late and on a system without system popt installed test
fails meaning wrong (system) getpass is used -> smbclient is unusable:

configure:14786: checking whether getpass should be replaced
configure:14813: cc -c -D_LONGLONG -Kll64 -O -O -D_LARGEFILE64_SOURCE
-I/tools/i
nclude -I/tools/src/samba-2.2.4/source/
-I/tools/src/samba-2.2.4/source/include 
-I/tools/src/samba-2.2.4/source/ubiqx
-I/tools/src/samba-2.2.4/source/smbwrapper
 conftest.c >&5
/usr/include/rpc/svc.h   245: [warning]:   CFE1932 type qualifier on return
type is meaningless
                        const void (*)(), 
                                   ^
 
/usr/include/rpc/svc.h   393: [warning]:   CFE1932 type qualifier on return
type is meaningless
  svc_create(const void (*)(const struct svc_req *, const SVCXPRT *), 
                        ^
 
/usr/include/rpc/svc.h   411: [warning]:   CFE1932 type qualifier on return
type is meaningless
  svc_tp_create(const void (*)(const struct svc_req *, const SVCXPRT *),
                           ^
 
/tools/src/samba-2.2.4/source/include/includes.h   689: [error]:   CFE1005
could not open source file "popt.h"
  #include "popt.h"
                   ^
 
/tools/src/samba-2.2.4/source/include/safe_string.h    46: [warning]:
CFE1881 macro defined differently than macro "pstrcat" (declared at line 299
of "/tools/include/ap_compat.h")
  #define pstrcat(d,s) safe_strcat((d),(s),sizeof(pstring)-1)
          ^
 
configure:14816: $? = 1
configure: failed program was:
#line 14795 "configure"
#include "confdefs.h"

#define REPLACE_GETPASS 1
#define NO_CONFIG_H 1
#define main dont_declare_main
#include "/tools/src/samba-2.2.4/source/lib/getsmbpass.c"
#undef main

int
main ()
{

  ;
  return 0;
}
configure:14834: result: no

regards

-andrej