[PATCH] poptify testparm

[Andrew Bartlett]

Andrew Bartlett wrote:
> 
> Jelmer Vernooij wrote:
> >
> > Hi,
> >
> > Here's another patch. This one makes the testparm utility use popt.
> >
> > Also did some reindenting, the current testparm.c contains a lot of
> > spaces..
> 
> You really should try and make sure that patches don't add 'const'
> warnings.
> 
> I'll chase these up myself this time, but always compile
> --enable-krb5-developer to ensure that you see all the warnings.

Another general hint on 'poptify' patches:

You need to update the Makefile.in to include the  @BUILD_POPT@, and you
need to ensure that you *don't* use automatic variables to initialse the
poptArgs struct (becouse some C compiles can't cope with that).  This
means making these variables static, or filling them out in the
function.

Andrew Bartlett,

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net