struct enum_csc_policy isn't terminated

Jeremy Allison jra at samba.org
Fri Jun 14 14:46:02 GMT 2002


On Fri, Jun 14, 2002 at 02:17:12PM +0900, Yasuma Takeda wrote:
> 
> In Samba-JP, a following problem was reported.
> 
> Since the "enum_csc_policy" struct doesn't terminate appropriately,
> it may occur buffer overflow. 
> 
> I confirmed this problem using by SWAT.
> The "csc policy" entry includes "enum_map_to_guest" struct entry.
> 
> This problem exists in 2.2.4 and HEAD.
> Please fix.
> 
> --- param/loadparm.c.020614	Mon Jun  3 20:23:28 2002
> +++ param/loadparm.c	Fri Jun 14 11:16:59 2002
> @@ -670,7 +670,8 @@
>  	{CSC_POLICY_MANUAL, "manual"},
>  	{CSC_POLICY_DOCUMENTS, "documents"},
>  	{CSC_POLICY_PROGRAMS, "programs"},
> -	{CSC_POLICY_DISABLE, "disable"}
> +	{CSC_POLICY_DISABLE, "disable"},
> +	{-1, NULL}
>  };
>  

Applied - thanks !

Jeremy.




More information about the samba-technical mailing list