Problem copying files from Win2k Novell client to Samba (repost)

Wade Turland w.turland at uws.edu.au
Fri Jun 7 00:55:02 GMT 2002


Perhaps there are 2 issues here. This seems to fit our problem description:
http://groups.google.com/groups?hl=en&lr=&threadm=c9f040de.0204170009.23153636%40posting.google.com&rnum=1&prev=/groups%3Fq%3Dadam%2Bthomas%2Bsamba%26hl%3Den%26lr%3D%26selm%3Dc9f040de.0204170009.23153636%2540posting.google.com%26rnum%3D1

It seems to be happening on Win2k clients whether they have Novell or not.

Let me know if you need some logs or something.

Wade.

Jeremy Allison has a copyright on recycled Internet traffic marked: >

> On Thu, Jun 06, 2002 at 12:40:46PM -0400, Dan Barrett wrote:
> > The problem I reported would occur with Samba 2.2.4, but not 2.2.2.  set_sd() in 2.2.4 returns False if the sd_len passed by the client is 0.  This would be okay, except Novell clients apparently set sd_len=0.
> >
> > To fix the novell problem, I changed set_sd() to return True, not False if sd_len==0.  I never got a response on why this code was added to 2.2.4.
> >
> > -Dan Barrett
> >
> > static BOOL set_sd(files_struct *fsp, char *data, uint32 sd_len, uint32 security_info_sent, int *pdef_class,uint32 *pdef_code)
> > {
> > 	prs_struct pd;
> > 	SEC_DESC *psd = NULL;
> > 	TALLOC_CTX *mem_ctx;
> > 	BOOL ret;
> >
> >
> > 	/* Stock Samba fails if sd_len==0, but some Novell client copies pass SMB requests with valid EA info, but no SD.  We want to allow these types of opens.*/
> > 	if (sd_len == 0) {
> > 		DEBUG(5,("set_sd: sd_len==0. Allowing anyway.\n"));
> > 		*pdef_class = 0;
> > 		*pdef_code = 0;
> > 		return True;
> > 	}
>
> In what SMB calls do the Novell clients set sd_len == 0 ?
> I can see allowing this in the NT_TRANSACT_CREATE call
> (which is the same as NTcreateAndX but supposedly with SD
> info as well), but not in the nt_transact_set_security_desc
> call, whose whole purpose is to set SD's.
>
> Can you give me some more info (ASAP if I'm going to get
> this fixed for 2.2.5 please).
>
> Jeremy.
>

-- 
/==============================================================\
|  Wade Turland                  | Locked Bag 1797             |
|  Unix Administrator            | Penrith South DC NSW 1797   |
|  University of Western Sydney  | Phone: +61 2 4736 0806      |
|  Room V137 (Kingswood)         | Fax:   +61 2 4736 0010      |
\==============================================================/
	How many seconds are there in a year?  If I tell you there  are
3.155  x  10^7, you won't even try to remember it.  On the other hand,
who could forget that, to within half a percent, pi seconds is a
nanocentury.
		-- Tom Duff, Bell Labs





More information about the samba-technical mailing list