patch for pdb_ldap.c (1.1.2.36)

[Markus Schabel]

so just putting a 0 instead of sizeof would be right here, because the string is
always empty (the string is a hardcoded "")?

Markus

PS: should this be a samba-technical or a samba-cvs discussion?

----- Original Message -----
From: "Simo Sorce" <idra at samba.org>
To: "Markus Schabel" <markus.schabel at chello.at>
Cc: "Tim Potter" <tpot at samba.org>; <samba-technical at lists.samba.org>
Sent: Friday, July 05, 2002 10:09 AM
Subject: Re: patch for pdb_ldap.c (1.1.2.36)


> You are right, for ldap, it is the lenght of that string, and sizeof()
> applied on pstring gives you back the max lenght of that (see the
> definition of pstring), instead the sizeof() method is wrong for
> allocated strings.
>
> Simo.
>
> On Fri, 2002-07-05 at 09:13, Markus Schabel wrote:
> > I thought the lengths should be the length of the string (parameter #3). At
> > least I saw this in another file (but don't ask which it was, I can't
remember
> > and have no source at the moment to check this....). But I've just started
to
> > read samba-source, so I've NO overview.....
> >
> > greetz
> > Markus
> >
> > ----- Original Message -----
> > From: "Tim Potter" <tpot at samba.org>
> > To: "Markus Schabel" <markus.schabel at chello.at>
> > Cc: <samba-technical at lists.samba.org>
> > Sent: Friday, July 05, 2002 8:56 AM
> > Subject: Re: patch for pdb_ldap.c (1.1.2.36)
> >
> >
> > > On Fri, Jul 05, 2002 at 08:34:43AM +0200, Markus Schabel wrote:
> > >
> > > > When compiling the actual cvs-tree with --with-ldapsam, there are some
> > compile
> > > > errors (not enough parameters for standard_sub_advance), the following
> > cvs -diff
> > > > pdb_ldap.c is a patch which correts this. At least I hope that it works
so
> > (it
> > > > compliles, but I've not tested if it runs....) - please correct me if
I'm
> > > > wrong....
> > >
> > > I think the lengths should be sizeof(whatever) instead of 0.  Fixed.
> > >
> > >
> > > Thanks,
> > >
> > > Tim.
> > >
> >
> >
> >
> --
> Simo Sorce
> ----------
> Una scelta di liberta': Software Libero.
> A choice of freedom: Free Software.
> http://www.softwarelibero.it