PATCH rpc server

Nigel Williams nigel at
Sat Jan 26 12:08:03 GMT 2002


I wasn't aware of any issues.  Tim would prefer not to see the silly_ptr
members in the future but changing that now would require a wholesale
rewrite of the share management client/server code.  IMHO the ptr members
reflect the structure seen on the wire and effectively document the NDR.
Wouldn't removing these members force the use of pointers to most top level
members in Q/R structures.  I'm thinking of the unmarshalling of the enum
structure.  The ptrs for all enumerated shares come first followed by the
data (strings etc) for all enumerated shares.  The value of the unmarshalled
ptr indicates whether data should be unmarshalled later. That information
has to be stored somewhere so we either have have a pointer to say the
UNISTR2 structure at the top level and allocate the structure if required or
some flag (ptr variable).

If you are all busy.  Maybe I can help with something?



> -----Original Message-----
> From: samba-technical-admin at
> [mailto:samba-technical-admin at]On Behalf Of Andrew
> Bartlett
> Sent: 26 January 2002 04:33
> To: Nigel Williams
> Cc: Andrew Bartlett; Samba-Technical at Samba. Org
> Subject: Re: PATCH rpc server
> Andrew Bartlett wrote:
> >
> > Nigel Williams wrote:
> > >
> > > This patch contains the rpc server modifications required by
> the addition of
> > > the share management client code
> > >
> > > nigel
> >
> > Just to let you know that I'll take on getting this into HEAD as one of
> > my projects for this week.  I'll do the client code as well.
> >
> > Thankyou *very* much - this patch looks pretty good!
> I've not yet got a chance to look a this - I've had other things on my
> plate.
> Have you managed to address some of the ideas that Tim put forward?
> Anyway, I'll *try* to take a look at this, but things are only getting
> busier.
> Andrew Bartlett
> --
> Andrew Bartlett                                 abartlet at
> Manager, Authentication Subsystems, Samba Team  abartlet at
> Student Network Administrator, Hawker College   abartlet at

More information about the samba-technical mailing list