Byte order problem in spoolss

Jeremy Allison jra at samba.org
Fri Jan 25 10:30:05 GMT 2002


On Sat, Jan 26, 2002 at 01:00:50AM +1100, Benjamin Kuit wrote:
> Earlier today I wrote in an email mentioning that my print queues
> doesn't show up submitted times of jobs, yet the time can be seen when
> you select the job and right-click for it's properties. I'm running
> Solaris on a sparc workstation.
> 
> Just confirmed that it's a byte-order problem and I've included
> a possible fix (or hack) for it.
> 
> In spoolss_notify_submitted_time (rpc_server/srv_spoolss_nt.c),
> the SYSTEMTIME structure (which is several uint16 values) is filled
> with the respective date, and then the contents of the structure is
> memcpy'd into the info_data stream, without regard to byte order.
> So I guess samba was telling my workstation that the jobs were
> submitted in year 53767?.
> 
> The problem doesn't exist when you right-click for job properties,
> because that time is parsed in though other routines, like
> spoolss_io_system_time(), which is apparently getting the byte order
> right.

Applied (a varient) thanks !

Jeremy.




More information about the samba-technical mailing list