[PATCH] Re: Plugable passdb (SAM) modules

[Andrew Bartlett]

"Stefan (metze) Metzmacher" wrote:
> 
> I think an option like
> ./configure --with-smbpasswd=static \
>                  --with-tdbsam=static  \
>                  --with-ldapsam=shared \
>                  --with-nisplus=shared
> would be nice, so the user can decide at compile time witch modules are
> static and witch have to be loaded via dlopen();
> ./configure --enable-shared-sam-modules=yes
> is the default on plattforms witch supports loaded modules
> but you can disable it if you want!
> ./configure --enable-shared-sam-modules=no
> 
> the init functions should look like this:
> 
> #ifdef WITH_TDBSAM
> ...
> tdbsam_pdb_functions()
> ...
> #ifdef WITH_TDBSAM_STATIC
> NTSTATUS pdb_init_ldapsam(PDB_CONTEXT *pdb_context, PDB_METHODS **pdb_method)
> #endif /* WITH_TDBSAM_STATIC */
> #ifdef WITH_TDBSAM_SHARED
> /* the "init" function is load via dlopen() */
> NTSTATUS init (PDB_CONTEXT *pdb_context, PDB_METHODS **pdb_method)
> #endif /* WITH_TDBSAM_SHARED */

NO!

For the reason outlined so well just there...  It looks horrid!  The
modules that come with samba should always be staticly compiled in - I
see no *need* for them to be outside smbd.  

Also, I don't think samba will ever default to needing modules becouse
it is such a pain to get right - you have to get smbd to look in the
right places etc.  The current system 'just works' - while allowing
other people to supply modules and do the legwork on getting smbd to
find them.

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net